Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary information from response #24056

Merged
merged 8 commits into from
May 17, 2023

Conversation

geido
Copy link
Member

@geido geido commented May 15, 2023

SUMMARY

This PR removes unnecessary information from API responses.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from dpgaspar May 15, 2023 13:56
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #24056 (d3de7e5) into master (f7dd52b) will increase coverage by 0.09%.
The diff coverage is 80.68%.

❗ Current head d3de7e5 differs from pull request most recent head 208814c. Consider uploading reports for the commit 208814c to get more accurate results

@@            Coverage Diff             @@
##           master   #24056      +/-   ##
==========================================
+ Coverage   68.22%   68.31%   +0.09%     
==========================================
  Files        1941     1951      +10     
  Lines       75261    75390     +129     
  Branches     8168     8185      +17     
==========================================
+ Hits        51344    51504     +160     
+ Misses      21828    21783      -45     
- Partials     2089     2103      +14     
Flag Coverage Δ
hive 53.19% <39.28%> (+0.01%) ⬆️
mysql 78.97% <57.14%> (+0.03%) ⬆️
postgres 79.04% <57.14%> (+0.03%) ⬆️
presto 53.12% <53.57%> (+0.02%) ⬆️
python 82.84% <92.85%> (+0.06%) ⬆️
sqlite 77.57% <53.57%> (+0.03%) ⬆️
unit 53.11% <75.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...n-chart-handlebars/src/plugin/controls/columns.tsx 15.78% <0.00%> (+0.78%) ⬆️
...frontend/src/SqlLab/components/ResultSet/index.tsx 63.05% <ø> (+0.39%) ⬆️
superset-frontend/src/components/Modal/Modal.tsx 85.89% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 2.04% <0.00%> (-0.05%) ⬇️
...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx 90.90% <ø> (+18.18%) ⬆️
...rc/dashboard/components/nativeFilters/selectors.ts 58.26% <ø> (ø)
...nd/src/dashboard/util/activeAllDashboardFilters.ts 60.00% <ø> (ø)
...shboard/util/charts/getFormDataWithExtraFilters.ts 88.88% <ø> (ø)
superset/charts/api.py 85.85% <ø> (ø)
... and 39 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 16, 2023
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geido geido merged commit 66fb486 into master May 17, 2023
@dpgaspar dpgaspar deleted the chore/rm-username-response branch May 19, 2023 14:40
@betodealmeida
Copy link
Member

We need username in owners in order to determine if the user is the owner of a dashboard or chart, eg see:

dashboard.owners.some(owner => owner.username === user.username);

I'll add it back.

@mistercrunch mistercrunch added 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L v2.1 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants