Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sqllab): remove deprecated PyArrow API #24135

Merged
merged 2 commits into from
May 20, 2023

Conversation

sebastianliebscher
Copy link
Contributor

@sebastianliebscher sebastianliebscher commented May 19, 2023

SUMMARY

As @wjones127 suggested in #24030 this PR removes deprecated .serialize and .deserialize. This enables upgrade to latest pyarrow==12.0.0.

Thank you @wjones127!

Resolves #24030

TESTING INSTRUCTIONS

./scripts/tests/run.sh

@sebastianliebscher
Copy link
Contributor Author

ping @EugeneTorap

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #24135 (2fb73da) into master (d583ca9) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 2fb73da differs from pull request most recent head 37144fc. Consider uploading reports for the commit 37144fc to get more accurate results

@@            Coverage Diff             @@
##           master   #24135      +/-   ##
==========================================
- Coverage   68.26%   68.24%   -0.02%     
==========================================
  Files        1952     1952              
  Lines       75388    75403      +15     
  Branches     8202     8203       +1     
==========================================
  Hits        51462    51462              
- Misses      21819    21834      +15     
  Partials     2107     2107              
Flag Coverage Δ
hive 53.24% <81.81%> (+<0.01%) ⬆️
mysql ?
postgres 79.01% <100.00%> (-0.01%) ⬇️
presto 53.16% <81.81%> (+<0.01%) ⬆️
python 82.77% <100.00%> (-0.04%) ⬇️
sqlite 77.55% <100.00%> (+<0.01%) ⬆️
unit 53.17% <36.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/dashboard/components/SliceHeader/index.tsx 90.74% <100.00%> (+0.17%) ⬆️
...dashboard/components/SliceHeaderControls/index.tsx 69.79% <100.00%> (+0.64%) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 57.52% <100.00%> (+1.55%) ⬆️
superset-frontend/src/logger/LogUtils.ts 97.22% <100.00%> (+0.07%) ⬆️
superset/sql_lab.py 86.36% <100.00%> (ø)
superset/sqllab/utils.py 100.00% <100.00%> (ø)
superset/views/utils.py 80.98% <100.00%> (+0.07%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the PyArrow end :)

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@villebro villebro merged commit 1583090 into apache:master May 20, 2023
@sebastianliebscher sebastianliebscher deleted the bump_pyarrow12 branch May 20, 2023 19:03
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql_lab.py uses PyArrow API that was removed in pyarrow 12.0.0
5 participants