-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sqllab): remove deprecated PyArrow API #24135
Conversation
ping @EugeneTorap |
Codecov Report
@@ Coverage Diff @@
## master #24135 +/- ##
==========================================
- Coverage 68.26% 68.24% -0.02%
==========================================
Files 1952 1952
Lines 75388 75403 +15
Branches 8202 8203 +1
==========================================
Hits 51462 51462
- Misses 21819 21834 +15
Partials 2107 2107
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the PyArrow end :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
SUMMARY
As @wjones127 suggested in #24030 this PR removes deprecated
.serialize
and.deserialize
. This enables upgrade to latest pyarrow==12.0.0.Thank you @wjones127!
Resolves #24030
TESTING INSTRUCTIONS
./scripts/tests/run.sh