Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reports): error when creation alert/report with localization #24159

Conversation

Always-prog
Copy link
Contributor

SUMMARY

Error was in translation type of report.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

2023-05-21_11-29-29.mp4

After

2023-05-21_11-28-16.mp4

TESTING INSTRUCTIONS

  1. Switch to russian language
  2. Try to create a report
  3. See the error

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #24159 (0fd8c54) into master (1583090) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 0fd8c54 differs from pull request most recent head 8ddec3e. Consider uploading reports for the commit 8ddec3e to get more accurate results

@@           Coverage Diff           @@
##           master   #24159   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files        1952     1952           
  Lines       75367    75367           
  Branches     8208     8208           
=======================================
  Hits        51455    51455           
  Misses      21806    21806           
  Partials     2106     2106           
Flag Coverage Δ
javascript 54.69% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/features/alerts/AlertReportModal.tsx 54.44% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit 09e399a into apache:master May 21, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants