Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extension hook for DB delete #24191

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Adds a simple onDelete callback for DB extra option extensions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #24191 (f48b553) into master (bc0079f) will decrease coverage by 0.69%.
The diff coverage is 50.00%.

❗ Current head f48b553 differs from pull request most recent head 8f981f8. Consider uploading reports for the commit 8f981f8 to get more accurate results

@@            Coverage Diff             @@
##           master   #24191      +/-   ##
==========================================
- Coverage   68.29%   67.61%   -0.69%     
==========================================
  Files        1955     1955              
  Lines       75506    75510       +4     
  Branches     8223     8224       +1     
==========================================
- Hits        51564    51053     -511     
- Misses      21834    22348     +514     
- Partials     2108     2109       +1     
Flag Coverage Δ
javascript 54.69% <50.00%> (-0.01%) ⬇️
mysql ?
postgres ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
superset-frontend/src/pages/DatabaseList/index.tsx 65.45% <50.00%> (-0.59%) ⬇️

... and 37 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida requested a review from lilykuang May 23, 2023 20:27
@betodealmeida betodealmeida merged commit 9df8d8d into master May 25, 2023
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request May 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the delete_database_extension branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants