Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tag link issue from CRUD page #24223

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 25, 2023

SUMMARY

Changing the reference URL to look all entities whenever the Tag is selected in the ListView CRUD

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #24223 (02ebd02) into master (9df8d8d) will not change coverage.
The diff coverage is n/a.

❗ Current head 02ebd02 differs from pull request most recent head ef43f4d. Consider uploading reports for the commit ef43f4d to get more accurate results

@@           Coverage Diff           @@
##           master   #24223   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files        1957     1957           
  Lines       75594    75594           
  Branches     8224     8224           
=======================================
  Hits        51637    51637           
  Misses      21849    21849           
  Partials     2108     2108           
Flag Coverage Δ
javascript 54.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Tags/Tag.tsx 62.50% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit 85b3401 into apache:master May 26, 2023
@hughhhh hughhhh deleted the fix-tag-query branch May 26, 2023 19:40
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants