Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): enabling and deprecating a few feature flags #24232

Merged
merged 6 commits into from
May 30, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented May 26, 2023

SUMMARY

Tagging this as feat because it enables flags by default. Could be a chore ¯\_(ツ)_/¯

As per the 3.0 task board:

  • Enabling thess flags as True by default,
    • ENABLE_TEMPLATE_REMOVE_FILTERS (item 37)
    • DRILL_TO_DETAIL (item 44)
    • DASHBOARD_CROSS_FILTERS (item 46)
  • Marking these flags as deprecated:
    • VERSIONED_EXPORT (item 36)
    • ENABLE_TEMPLATE_REMOVE_FILTERS (item 37)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas changed the title feat(flags): enabling DASHBOARD_CROSS_FILTERS and DRILL_TO_DETAIL feat(flags): enabling and deprecating a few feature flags May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #24232 (5269c41) into master (50535e4) will decrease coverage by 0.06%.
The diff coverage is 27.77%.

❗ Current head 5269c41 differs from pull request most recent head b8882ed. Consider uploading reports for the commit b8882ed to get more accurate results

@@            Coverage Diff             @@
##           master   #24232      +/-   ##
==========================================
- Coverage   68.30%   68.25%   -0.06%     
==========================================
  Files        1957     1957              
  Lines       75594    75596       +2     
  Branches     8224     8222       -2     
==========================================
- Hits        51637    51600      -37     
- Misses      21849    21888      +39     
  Partials     2108     2108              
Flag Coverage Δ
hive 53.37% <100.00%> (+<0.01%) ⬆️
mysql 78.92% <100.00%> (+<0.01%) ⬆️
postgres 78.99% <100.00%> (+<0.01%) ⬆️
presto ?
python 82.71% <100.00%> (-0.11%) ⬇️
sqlite 77.53% <100.00%> (+<0.01%) ⬆️
unit 53.39% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...nd/src/components/ErrorMessage/BasicErrorAlert.tsx 93.75% <ø> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx 5.66% <0.00%> (-0.06%) ⬇️
superset/config.py 92.00% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 55.36% <28.57%> (+0.19%) ⬆️
...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx 83.33% <100.00%> (+3.33%) ⬆️
superset/datasets/schemas.py 97.48% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit d1c57e0 into master May 30, 2023
@rusackas rusackas deleted the enabling-2-flags-by-default branch July 14, 2023 16:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants