Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support complex types and use get_columns implementation of starrrocks python client #24237

Merged
merged 4 commits into from
Jun 8, 2023

Conversation

miomiocat
Copy link
Contributor

@miomiocat miomiocat commented May 29, 2023

SUMMARY

  1. support complex types:
  • largeint
  • json
  • percentile
  • hll
  • bitmap
  1. remove get_columns from db_spec to use the dialect's implementation of starrocks own python client
  2. update logo image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #24237 (3e1dd10) into master (e13b80a) will increase coverage by 0.01%.
The diff coverage is 90.90%.

❗ Current head 3e1dd10 differs from pull request most recent head 9c97bec. Consider uploading reports for the commit 9c97bec to get more accurate results

@@            Coverage Diff             @@
##           master   #24237      +/-   ##
==========================================
+ Coverage   68.33%   68.35%   +0.01%     
==========================================
  Files        1957     1957              
  Lines       75628    75609      -19     
  Branches     8225     8225              
==========================================
  Hits        51680    51680              
+ Misses      21835    21816      -19     
  Partials     2113     2113              
Flag Coverage Δ
hive 53.42% <90.90%> (+0.02%) ⬆️
javascript 54.76% <ø> (ø)
mysql 78.96% <90.90%> (+0.04%) ⬆️
postgres 79.04% <90.90%> (+0.04%) ⬆️
presto 53.34% <90.90%> (+0.02%) ⬆️
python 82.86% <90.90%> (+0.04%) ⬆️
sqlite 77.57% <90.90%> (+0.04%) ⬆️
unit 53.47% <90.90%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/starrocks.py 87.69% <90.90%> (+19.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@miomiocat
Copy link
Contributor Author

miomiocat commented May 29, 2023

@villebro @rusackas Could you help me review this PR?

@rusackas
Copy link
Member

Looks reasonable to me, but deferring to @john-bodley @betodealmeida and @villebro who will be better at spotting the "gotchas" than I am ;) Much appreciated!

@john-bodley
Copy link
Member

Thanks @miomiocat for the PR. Would you mind:

  1. Resolving the merge conflict.
  2. Running tox -e pre-commit locally? We added the pyupgrade hook which rewrites type hints.

@miomiocat
Copy link
Contributor Author

Thanks @miomiocat for the PR. Would you mind:

  1. Resolving the merge conflict.
  2. Running tox -e pre-commit locally? We added the pyupgrade hook which rewrites type hints.

Done, please take a look at this PR

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvements, cleanup and added tests 👍 While I kinda would prefer the transparent background on the logo, the dark text would make it illegible on dark mode if the background were to be dark, so maybe it's better like this.

@rusackas rusackas merged commit fd3effe into apache:master Jun 8, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants