Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(capitalization): Capitalizing the 'metric' label in Pivot Tables #24265

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jun 1, 2023

SUMMARY

Capitalizing the 'metric' header according to capitalization guidelines.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #24265 (e01a63f) into master (f6e769a) will not change coverage.
The diff coverage is 0.00%.

❗ Current head e01a63f differs from pull request most recent head ae00092. Consider uploading reports for the commit ae00092 to get more accurate results

@@           Coverage Diff           @@
##           master   #24265   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files        1957     1957           
  Lines       75597    75597           
  Branches     8222     8222           
=======================================
  Hits        51641    51641           
  Misses      21848    21848           
  Partials     2108     2108           
Flag Coverage Δ
javascript 54.72% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit 46c2479 into master Jun 7, 2023
@rusackas rusackas deleted the capitalize-metric-label branch July 14, 2023 16:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants