fix(migrations): Fixing cross filter migration #24279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
reviewed
Jun 2, 2023
Comment on lines
+106
to
+109
|
|
||
| if "global_chart_configuration" in json_metadata: | ||
| del json_metadata["global_chart_configuration"] | ||
|
|
There was a problem hiding this comment.
nit:
Suggested change
| if "global_chart_configuration" in json_metadata: | |
| del json_metadata["global_chart_configuration"] | |
| json_metadata.pop('global_chart_configuration') |
There was a problem hiding this comment.
.pop() fails if the key doesn't exist:
>>> {}.pop(1)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
KeyError: 1
Codecov Report
@@ Coverage Diff @@
## master #24279 +/- ##
==========================================
+ Coverage 68.29% 68.31% +0.01%
==========================================
Files 1957 1957
Lines 75624 75624
Branches 8223 8223
==========================================
+ Hits 51649 51664 +15
+ Misses 21867 21852 -15
Partials 2108 2108
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🏷️ preset:2023.21 |
zcong1993
pushed a commit
to zcong1993/incubator-superset
that referenced
this pull request
Jun 3, 2023
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 3, 2023
(cherry picked from commit c5ea40f)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixing bug in down migration for Cross Filtering