Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): Fixing cross filter migration #24279

Merged

Conversation

craig-rueda
Copy link
Member

SUMMARY

Fixing bug in down migration for Cross Filtering

@craig-rueda craig-rueda requested a review from a team as a code owner June 2, 2023 22:21
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go

Comment on lines +106 to +109

if "global_chart_configuration" in json_metadata:
del json_metadata["global_chart_configuration"]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
if "global_chart_configuration" in json_metadata:
del json_metadata["global_chart_configuration"]
json_metadata.pop('global_chart_configuration')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.pop() fails if the key doesn't exist:

>>> {}.pop(1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
KeyError: 1

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #24279 (a47bf4f) into master (1d9a761) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a47bf4f differs from pull request most recent head 0a736b5. Consider uploading reports for the commit 0a736b5 to get more accurate results

@@            Coverage Diff             @@
##           master   #24279      +/-   ##
==========================================
+ Coverage   68.29%   68.31%   +0.01%     
==========================================
  Files        1957     1957              
  Lines       75624    75624              
  Branches     8223     8223              
==========================================
+ Hits        51649    51664      +15     
+ Misses      21867    21852      -15     
  Partials     2108     2108              
Flag Coverage Δ
hive 53.39% <ø> (ø)
mysql 78.92% <ø> (?)
postgres 79.00% <ø> (ø)
presto 53.32% <ø> (ø)
python 82.82% <ø> (+0.04%) ⬆️
sqlite 77.53% <ø> (ø)
unit 53.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 2, 2023
@sadpandajoe
Copy link
Member

🏷️ preset:2023.21

zcong1993 pushed a commit to zcong1993/incubator-superset that referenced this pull request Jun 3, 2023
@jinghua-qa jinghua-qa merged commit c5ea40f into apache:master Jun 3, 2023
@jinghua-qa jinghua-qa deleted the craig/fixing_crossfilter_migration branch June 3, 2023 00:23
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jun 3, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants