Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Adds new permissions from 2.1.0 and fixes some sql_lab permissions #24288

Merged
merged 1 commit into from
Jun 5, 2023
Merged

docs: Adds new permissions from 2.1.0 and fixes some sql_lab permissions #24288

merged 1 commit into from
Jun 5, 2023

Conversation

mattitoo
Copy link
Contributor

@mattitoo mattitoo commented Jun 5, 2023

SUMMARY

2.1.0 added some new permission, that are not reflected yet. Also some permissions for the sql_lab role seem to have missed before.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

villebro
villebro approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update! LGTM

zhaoyongjie
zhaoyongjie approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't realized this document before. LGTM, Thanks for updating docs.

dpgaspar
dpgaspar approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dpgaspar dpgaspar merged commit cab34c2 into apache:master Jun 5, 2023
@mattitoo mattitoo deleted the docs-update_standard_roles branch June 7, 2023 07:54
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@dpgaspar dpgaspar dpgaspar approved these changes

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattitoo @zhaoyongjie @dpgaspar @villebro @mistercrunch