chore: Update GitHub issue templates #24310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda and
kgabryje
as code owners
john-bodley
force-pushed
the
john-bodley--fix-github-issues
branch
4 times, most recently
from
f366284
to
b400092
Compare
john-bodley
commented
Jun 8, 2023
| @@ -1,10 +1,10 @@ | |||
| --- | |||
| name: SIP | |||
| about: Superset Improvement Proposal (See SIP-0: https://github.com/apache/superset/issues/5602) | |||
There was a problem hiding this comment.
The : was problematic for YAML which voided the template.
john-bodley
force-pushed
the
john-bodley--fix-github-issues
branch
from
b400092
to
9d6118e
Compare
john-bodley
force-pushed
the
john-bodley--fix-github-issues
branch
from
9d6118e
to
74aadf7
Compare
rusackas
approved these changes
Jun 10, 2023
| @@ -1,10 +1,9 @@ | |||
| --- | |||
| name: SIP | |||
| about: Superset Improvement Proposal (See SIP-0: https://github.com/apache/superset/issues/5602) | |||
There was a problem hiding this comment.
Might wanna get rid of that last parenthesis as well
There was a problem hiding this comment.
@rusackas could you be more specific which parenthesis is wrong?
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updating the GitHub issue templates to ensure they adhere to the standard.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION