-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dao): Organize DAOs according to SIP-92 #24331
chore(dao): Organize DAOs according to SIP-92 #24331
Conversation
f821d86
to
3e96de1
Compare
28d5321
to
74cbdbb
Compare
Codecov Report
@@ Coverage Diff @@
## master #24331 +/- ##
==========================================
- Coverage 68.93% 68.91% -0.02%
==========================================
Files 1904 1899 -5
Lines 73878 73842 -36
Branches 8119 8119
==========================================
- Hits 50927 50891 -36
Misses 20840 20840
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d72160e
to
d330219
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
"one exception is exceptions" :)
d330219
to
407fa70
Compare
407fa70
to
aafa73c
Compare
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
SUMMARY
This PR is the first of many to related to SIP-92 Proposal for restructuring the Python code base. Specifically it organizes all the DAOs under the
superset/daos
subfolder. A few things of note:EmbeddedDAO
was renamedEmbeddedDashboardDAO
for clarity.AnnotationLayerDAO
is housed indaos/annotation.py
EmbeddedDashboardDAO
andFilterSetDAO
are housed indaos/dashboard.py
SavedQueryDAO
is housed indaos/query.py
SSHTunnelDAO
is housed indaos/database.py
dashboard
ordashboards
. I opted for the former given that:daos
(plural) subfolder.dashboard.py
file contains a collection of DAOs (DashboardDAO
,EmbeddedDashboardDAO
) we tend to think of the term "dashboard" as a concept/type rather than multiple types.exceptions
as this houses different exception types and is consistent with how other files containing exceptions are named.css_templates/dao.py
becamedaos/css.py
row_level_security/dao.py
becamedaos/security.py
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION