Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated api /superset/override_role_permissions #24334

Closed

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jun 9, 2023

SUMMARY

Removes old deprecated API /superset/override_role_permissions/

Related with the ongoing effort for removing deprecated APIs from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #24334 (c5dde0b) into master (af8f725) will decrease coverage by 11.11%.
The diff coverage is n/a.

❗ Current head c5dde0b differs from pull request most recent head 2823b9f. Consider uploading reports for the commit 2823b9f to get more accurate results

@@             Coverage Diff             @@
##           master   #24334       +/-   ##
===========================================
- Coverage   69.08%   57.97%   -11.11%     
===========================================
  Files        1905     1905               
  Lines       74849    74823       -26     
  Branches     8108     8108               
===========================================
- Hits        51706    43380     -8326     
- Misses      21031    29331     +8300     
  Partials     2112     2112               
Flag Coverage Δ
hive 53.69% <ø> (+0.02%) ⬆️
mysql ?
postgres ?
presto 53.62% <ø> (+0.02%) ⬆️
python 60.46% <ø> (-22.81%) ⬇️
sqlite ?
unit 54.11% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 36.82% <ø> (-38.46%) ⬇️

... and 302 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina
Copy link
Member

Could you add something to Breaking Changes in UPDATING.md?

@dpgaspar
Copy link
Member Author

closed in favour of #24266

@dpgaspar dpgaspar closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants