Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable redux errors #24362

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jun 12, 2023

SUMMARY

Due to long standing issues with Superset's redux store, recently introduced redux-toolkit produces hundreds of console errors related to violating state immutability and saving un-serializable objects. Though the errors are accurate, they make development work harder due to cluttering the browser console. This PR disables the Redux middleware responsible for issuing those errors by default.
If you'd like to enable those errors to work on improving the Redux state, you can do that by setting env variable REDUX_DEFAULT_MIDDLEWARE to true. To do that, you can run frontend with the following script:

REDUX_DEFAULT_MIDDLEWARE=true npm run dev-server

or

export REDUX_DEFAULT_MIDDLEWARE=true
npm run dev-server

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @kgabryje.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #24362 (5cf6ce1) into master (e0253a4) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 5cf6ce1 differs from pull request most recent head 543e6ef. Consider uploading reports for the commit 543e6ef to get more accurate results

@@            Coverage Diff             @@
##           master   #24362      +/-   ##
==========================================
- Coverage   69.04%   69.04%   -0.01%     
==========================================
  Files        1903     1903              
  Lines       74564    74565       +1     
  Branches     8107     8108       +1     
==========================================
  Hits        51485    51485              
  Misses      20968    20968              
- Partials     2111     2112       +1     
Flag Coverage Δ
javascript 55.61% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/store.ts 75.00% <50.00%> (-3.27%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit e4bb4a4 into apache:master Jun 12, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants