Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deck.gl Scatterplot min/max radius #24363

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

Fixes setting min/max radius in deck.gl Scatterplot chart. Sometimes when user changed the value the circles would disappear, because the input was actually treated as a string and deck.gl expects a number

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #24363 (0739330) into master (e0253a4) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 0739330 differs from pull request most recent head b5e85c7. Consider uploading reports for the commit b5e85c7 to get more accurate results

@@           Coverage Diff           @@
##           master   #24363   +/-   ##
=======================================
  Coverage   69.04%   69.04%           
=======================================
  Files        1903     1903           
  Lines       74564    74564           
  Branches     8107     8107           
=======================================
  Hits        51485    51485           
  Misses      20968    20968           
  Partials     2111     2111           
Flag Coverage Δ
javascript 55.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...preset-chart-deckgl/src/layers/Scatter/Scatter.jsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit c728cdf into apache:master Jun 12, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants