-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make data tables support html #24368
Conversation
The feature is very best,I need it too. But, I hope to that, Add a config item by Web UI ,rather than CONCAT In sql , What are your ideas ? @mistercrunch |
Codecov Report
@@ Coverage Diff @@
## master #24368 +/- ##
==========================================
- Coverage 69.05% 68.99% -0.06%
==========================================
Files 1903 1904 +1
Lines 74530 74144 -386
Branches 8105 8120 +15
==========================================
- Hits 51464 51157 -307
+ Misses 20955 20875 -80
- Partials 2111 2112 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I think the concat is nice in that it allows you to re-use the columnar data anywhere needed in the link. For example, a Github issue ID is used as the linked text AND a particular spot in the URL. If we were to add a link to the UI, we would need some form of syntax (e.g. handlebars/jinja) that would allow you to construct the link in the correct way... and that can have security-related concerns. I love the idea of it being in the UI, but I'm having a hard time thinking of a way to do it that's both simple and secure. |
Hmm, I was just looking into adding this support to the pivot tables too. |
YES, I got it, thanks |
Will this work in just regular Table charts? Like by applying custom SQL to fields I have in the table using concatenate? Or just SQLlab? |
SUMMARY
allowing links and other basic HTML to render in data tables safely. This tackles:
Results
Samples
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION