Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove previously deprecated dataset metrics column from RESTful API #24401

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

john-bodley
Copy link
Member

SUMMARY

Following up on an action item from #20732 removing a column (which was previously blossomed and slated for removal in Superset 3.0).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@@ -163,7 +163,6 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"columns.type",
"columns.uuid",
"columns.verbose_name",
"metrics", # TODO(john-bodley): Deprecate in 3.0.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment was wrong, i.e., it should have said "remove" as opposed to "deprecate".

@john-bodley john-bodley changed the title chore: Remove previously deprecated dataset column from RESTful API chore: Remove previously deprecated dataset metrics column from RESTful API Jun 14, 2023
@john-bodley john-bodley marked this pull request as ready for review June 14, 2023 16:17
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #24401 (af555d0) into master (c69634d) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head af555d0 differs from pull request most recent head b035150. Consider uploading reports for the commit b035150 to get more accurate results

@@            Coverage Diff             @@
##           master   #24401      +/-   ##
==========================================
+ Coverage   68.90%   68.95%   +0.04%     
==========================================
  Files        1903     1903              
  Lines       74070    74070              
  Branches     8110     8110              
==========================================
+ Hits        51041    51077      +36     
+ Misses      20917    20881      -36     
  Partials     2112     2112              
Flag Coverage Δ
hive 53.86% <ø> (ø)
mysql 79.26% <ø> (?)
postgres 79.34% <ø> (+<0.01%) ⬆️
presto 53.79% <ø> (ø)
python 83.31% <ø> (+0.10%) ⬆️
sqlite 77.83% <ø> (?)
unit 54.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/api.py 87.95% <ø> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eschutho eschutho added the risk:breaking-change Issues or PRs that will introduce breaking changes label Jun 14, 2023
@john-bodley john-bodley merged commit fcf7cba into master Jun 14, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the john-bodley--remove-deprecated-dataset-column branch March 26, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants