Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: creating a new chart with dashboard time filters but filter can't apply again #24405

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

lilykuang
Copy link
Member

SUMMARY

How to reproduce the bug

  • Create a chart and add it to a dashboard.
  • Add a time range filter to the dashboard.
  • Apply any value to this filter.
  • Access the chart from the dashboard.
  • Save to to a new chart, and add it to the same dashboard. Explore would reload and the temporal filter would be removed (expected).
  • Navigate back to the dashboard, and apply a temporal filter.

Expected results
The temporal filter gets applied to the new chart.

Actual results
The filter is not applied to the new chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
old

After:
new

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang marked this pull request as ready for review June 20, 2023 17:06
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #24405 (45f1fe1) into master (19a9400) will increase coverage by 0.07%.
The diff coverage is 90.67%.

❗ Current head 45f1fe1 differs from pull request most recent head 564716f. Consider uploading reports for the commit 564716f to get more accurate results

@@            Coverage Diff             @@
##           master   #24405      +/-   ##
==========================================
+ Coverage   68.95%   69.03%   +0.07%     
==========================================
  Files        1903     1901       -2     
  Lines       74070    74002      -68     
  Branches     8110     8116       +6     
==========================================
+ Hits        51077    51084       +7     
+ Misses      20881    20807      -74     
+ Partials     2112     2111       -1     
Flag Coverage Δ
javascript 55.64% <69.69%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/superset-ui-chart-controls/src/constants.ts 100.00% <ø> (ø)
...erset-ui-chart-controls/src/utils/columnChoices.ts 100.00% <ø> (ø)
.../superset-ui-core/src/models/ExtensibleFunction.ts 100.00% <ø> (ø)
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...acy-preset-chart-deckgl/src/components/Tooltip.tsx 0.00% <0.00%> (ø)
...preset-chart-deckgl/src/layers/Geojson/Geojson.jsx 0.00% <0.00%> (ø)
...et-chart-deckgl/src/layers/Geojson/controlPanel.ts 50.00% <ø> (ø)
...lugins/plugin-chart-table/src/utils/formatValue.ts 66.66% <0.00%> (-3.93%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 69.16% <ø> (-0.27%) ⬇️
... and 175 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lilykuang lilykuang merged commit 6dba6e3 into apache:master Jun 20, 2023
@lilykuang lilykuang deleted the fix-dashboard-time-filters branch June 20, 2023 21:39
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Jun 21, 2023
jinghua-qa added a commit to preset-io/superset that referenced this pull request Jun 22, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants