-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Scarf Gateway for Superset npm downloads #24433
Conversation
Adding a note here that docs are added on the related PR: #24432 |
Co-authored-by: Evan Rusackas <evan@preset.io>
6e9b21a
to
ec12a92
Compare
Codecov Report
@@ Coverage Diff @@
## master #24433 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 1901 1901
Lines 73927 73927
Branches 8183 8183
=======================================
Hits 50932 50932
Misses 20874 20874
Partials 2121 2121
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Arjun Devarajan <arjun.devarajan@scarf.sh> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Evan Rusackas <evan@rusackas.com>
Co-authored-by: Arjun Devarajan <arjun.devarajan@scarf.sh> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Evan Rusackas <evan@rusackas.com>
SUMMARY
This PR updates the Superset configuration for npm by adding scarf-js as a dependency. This allows Superset maintainers to collect basic de-identified download and adoption metrics. These metrics include which versions of superset are being installed and the origin of installation (git, etc.). This does not have a runtime footprint and adds no additional dependencies beyond itself.
This change was suggested by Superset maintainers in direct discussions. There is also a pull request for updating the Docker compose and helm charts installation methods to retrieve metrics from those pathways.
Scarf purges PII and provides aggregated statistics. Superset users can easily opt out of analytics in various ways documented here and here.
TESTING INSTRUCTIONS
To test this, download Apache Superset using general npm methodology and verify that Apache Superset downloads without issue.
ADDITIONAL INFORMATION