Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: toning down grayscale on X icon #24437

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jun 16, 2023

Cosmetics! Here's the after ->
Screen Shot 2023-06-16 at 3 27 06 PM

From another env, this PR will help make this much more clear ->
Screen Shot 2023-06-16 at 3 28 08 PM

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #24437 (9f5e910) into master (20e0036) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9f5e910 differs from pull request most recent head f941ee1. Consider uploading reports for the commit f941ee1 to get more accurate results

@@           Coverage Diff           @@
##           master   #24437   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files        1904     1904           
  Lines       73879    73879           
  Branches     8119     8119           
=======================================
  Hits        50928    50928           
  Misses      20840    20840           
  Partials     2111     2111           
Flag Coverage Δ
javascript 55.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/pages/DatabaseList/index.tsx 65.45% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit 79a18d4 into apache:master Jun 18, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants