fix: Revert enabling CSP #24476
Merged
fix: Revert enabling CSP #24476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c3b5d72.
kgabryje
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| crossorigin="anonymous" | ||
| nonce="{{ csp_nonce() }}"></script> | ||
| <script src="{{ assets_prefix }}/static/assets/stylesheets/less/cosmo/cosmoTheme.js" nonce="{{ csp_nonce() }}"></script> | ||
| <script src="https://code.jquery.com/jquery-1.10.2.min.js"></script> |
Check warning
Code scanning / CodeQL
Inclusion of functionality from an untrusted source
Codecov Report
@@ Coverage Diff @@
## master #24476 +/- ##
==========================================
- Coverage 69.03% 69.00% -0.03%
==========================================
Files 1901 1901
Lines 74002 74001 -1
Branches 8116 8116
==========================================
- Hits 51086 51067 -19
- Misses 20805 20823 +18
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dpgaspar
approved these changes
Jun 21, 2023
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This reverts commit c3b5d72.
When
TALISMAN_ENABLEDff is set to False,csp_noncejinja function is undefined. Reverting until I fix this bugBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION