-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sqllab): add extra_json on tabstate #24489
chore(sqllab): add extra_json on tabstate #24489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24489 +/- ##
==========================================
+ Coverage 69.01% 69.08% +0.07%
==========================================
Files 1901 1901
Lines 74034 74019 -15
Branches 8119 8116 -3
==========================================
+ Hits 51091 51135 +44
+ Misses 20835 20767 -68
- Partials 2108 2117 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinpark You can use the extra
property in ExtraJSONMixin
which is part of TabState
.
a70fb32
to
4c3c03b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit e20b695.
SUMMARY
This commit includes the
extra_json
attribute on tabstate view in order to sync the latest async updated time used in SIP-93BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
check the bootstrap data in sqllab including
extra_json
ADDITIONAL INFORMATION