Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): pin the underlying debain base image #24497

Merged
merged 1 commit into from
Jun 23, 2023
Merged

build(docker): pin the underlying debain base image #24497

merged 1 commit into from
Jun 23, 2023

Conversation

boenshao
Copy link
Contributor

@boenshao boenshao commented Jun 23, 2023

SUMMARY

The slim Python images are based on the latest Debian release.

Debian 12 Bookworm was released two weeks ago and I've seen some projects break because the APT packages they relied on are not available anymore.

As Superset does use apt-get during the build, it's better to pin the underlying Debian base image. This probably won't be an issue for a long time though...

TESTING INSTRUCTIONS

Manually build from the Dockerfile,

docker build --target lean -t superset .

In stdout, we should see that the image is built from 3.9-slim-bookworm,

Sending build context to Docker daemon    127MB
Step 1/31 : ARG PY_VER=3.9-slim-bookworm

And the build should finish without error.

Successfully tagged superset:latest

@craig-rueda craig-rueda merged commit e6f7c73 into apache:master Jun 23, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants