-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docker): add dockerize image #24534
Conversation
Hi all!
Maybe someone can advise? |
dockerize.Dockerfile
Outdated
@@ -0,0 +1,14 @@ | |||
FROM alpine:latest | |||
|
|||
ARG DOCKERIZE_VERSION=v0.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? I think it's preferable to just switch over to the "official" image. Or I wonder if we could use busybox or something? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@craig-rueda I don't understand what you mean by "official". I found only this repository on dockerhub (on the attached image). The youngest image from there is 4 years old. If I did not find a link to some official image, then I would be grateful if you show it to me, and I, in turn, could study this issue.
About the busybox image: dockereze requires openssl to work, and busybox doesn't have a package manager to install it, so in my opinion the best way is to use the alpine base image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense. I wasn't sure what we were using that image for in the first place 😄 . I see what's going on here - you're moving us to "official" (apache) ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this image in order to expect connection to postgreSQL and Redis. If you do not use this image, then users may make an error when starting the chart and will endlessly receive a crashloopbackoff, and this image in the work logs clearly shows that the connection failed and repeats attempts to contact the destination (in my opinion, this is a good idea ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI is failing, otherwise LGTM
build(docker): add dockerize image
@craig-rueda I managed to solve the problem - now all processes work correctly! |
Co-authored-by: Aleksey Karpov <al.karpov@okko.tv>
The Dockerezer image currently on the Helm Chart is too old and has critical vulnerabilities, for example:
busybox, 1.26.2-r5, CVE-2017-16544 (https://nvd.nist.gov/vuln/detail/CVE-2017-16544)
This pr is designed to solve this problem
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION