Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add description column to Tags #24553

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jun 29, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh requested a review from a team as a code owner June 29, 2023 18:45
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #24553 (33f812e) into master (38df1a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 33f812e differs from pull request most recent head b148e1c. Consider uploading reports for the commit b148e1c to get more accurate results

@@           Coverage Diff           @@
##           master   #24553   +/-   ##
=======================================
  Coverage   69.08%   69.08%           
=======================================
  Files        1906     1906           
  Lines       74114    74115    +1     
  Branches     8155     8155           
=======================================
+ Hits        51200    51201    +1     
  Misses      20795    20795           
  Partials     2119     2119           
Flag Coverage Δ
hive 53.92% <100.00%> (+<0.01%) ⬆️
mysql 79.40% <100.00%> (+<0.01%) ⬆️
postgres 79.48% <100.00%> (+<0.01%) ⬆️
presto 53.82% <100.00%> (+<0.01%) ⬆️
python 83.48% <100.00%> (+<0.01%) ⬆️
sqlite 78.04% <100.00%> (+<0.01%) ⬆️
unit 54.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/tags/models.py 93.54% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit 19deb91 into apache:master Jun 29, 2023
@hughhhh hughhhh deleted the tags-decription branch June 29, 2023 20:23
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants