-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sqllab): Log current local storage usage #24554
chore(sqllab): Log current local storage usage #24554
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24554 +/- ##
==========================================
+ Coverage 69.06% 69.08% +0.02%
==========================================
Files 1901 1906 +5
Lines 74019 74126 +107
Branches 8116 8156 +40
==========================================
+ Hits 51121 51211 +90
- Misses 20787 20795 +8
- Partials 2111 2120 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
queryCount, | ||
); | ||
} | ||
if (localStorageUsageInKilobytes > 0 && !this.hasLoggedLocalStorageUsage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is only the initial local storage usage monitored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right.
Co-authored-by: Justin Park <justinpark@apache.org> (cherry picked from commit 0836000)
Co-authored-by: Justin Park <justinpark@apache.org>
SUMMARY
This commit adds a logging event for the current local storage size for monitoring purpose.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Before: N/A
TESTING INSTRUCTIONS
Go to SQLLab and check the network tab for the logging event
ADDITIONAL INFORMATION