Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better styling alerts/reports modal #24558

Merged
merged 2 commits into from
Jun 30, 2023
Merged

chore: better styling alerts/reports modal #24558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4324f
fix: heads
betodealmeida Jun 29, 2023
a300aaf
chore: better styling alerts/reports modal
betodealmeida Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions superset-frontend/src/features/alerts/AlertReportModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,15 @@ export const StyledInputContainer = styled.div`
flex: 1;
margin-top: 0;
input::-webkit-outer-spin-button,
input::-webkit-inner-spin-button {
-webkit-appearance: none;
margin: 0;
}
input[type='number'] {
-moz-appearance: textfield;
}
.helper {
display: block;
color: ${({ theme }) => theme.colors.grayscale.base};
Expand Down Expand Up @@ -332,8 +341,7 @@ const StyledRadioGroup = styled(Radio.Group)`
`;

const StyledCheckbox = styled(AntdCheckbox)`
margin-left: ${({ theme }) => theme.gridUnit * 5.5}px;
margin-top: ${({ theme }) => theme.gridUnit}px;
margin-top: ${({ theme }) => theme.gridUnit * 2}px;
`;

// Notification Method components
Expand Down
4 changes: 2 additions & 2 deletions superset/migrations/versions/2023-06-29_18-38_240d23c7f86f_update_tag_model_w_description.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
"""update_tag_model_w_description
Revision ID: 240d23c7f86f
Revises: 6fbe660cac39
Revises: 8e5b0fb85b9a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this fixing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have 2 heads in Alembic, this chains the 2 (independent heads) so there's just one.

Create Date: 2023-06-29 18:38:30.033529
"""

# revision identifiers, used by Alembic.
revision = "240d23c7f86f"
down_revision = "6fbe660cac39"
down_revision = "8e5b0fb85b9a"

import sqlalchemy as sa
from alembic import op
Expand Down