fix: docker compose refusing to start #24565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
reviewed
Jun 30, 2023
docker/docker-bootstrap.sh
Outdated
| @@ -46,7 +46,7 @@ case "${1}" in | |||
| celery --app=superset.tasks.celery_app:app beat --pidfile /tmp/celerybeat.pid -l INFO -s "${SUPERSET_HOME}"/celerybeat-schedule | |||
| ;; | |||
| app) | |||
| echo "Starting web app..." | |||
| echo "Starting web app on debug..." | |||
There was a problem hiding this comment.
I'm probably missing something, but isn't this conditional on FLASK_DEBUG being set to true?
There was a problem hiding this comment.
You're right, but there's the debugger and the debug on flask
"The debugger is enabled by default when the development server is run in debug mode."
adding "debug" here is not correct, I want to differentiate between starting with Flask or gunicorn
villebro
approved these changes
Jun 30, 2023
|
Insightful |
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently
docker-compose upis refusing to start since debug is not enabled anymore.We now use
FLASK_DEBUG=truesinceFLASK_ENVis deprecatedThis is a small fix for it
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION