Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove underscore from builtin_time_grains label #24567

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

cnabro
Copy link
Contributor

@cnabro cnabro commented Jun 30, 2023

SUMMARY

  • remove underscore from builtin_time_grains label
  • image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member

Thanks for the fix @cnabro!

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #24567 (0f4ac3c) into master (ba3bdc0) will increase coverage by 0.00%.
The diff coverage is 80.60%.

❗ Current head 0f4ac3c differs from pull request most recent head 0e086fb. Consider uploading reports for the commit 0e086fb to get more accurate results

@@           Coverage Diff            @@
##           master   #24567    +/-   ##
========================================
  Coverage   69.06%   69.07%            
========================================
  Files        1901     1906     +5     
  Lines       74019    74159   +140     
  Branches     8116     8161    +45     
========================================
+ Hits        51121    51223   +102     
- Misses      20787    20817    +30     
- Partials     2111     2119     +8     
Flag Coverage Δ
hive 53.93% <68.14%> (+0.03%) ⬆️
mysql ?
postgres 79.47% <85.84%> (-0.03%) ⬇️
presto 53.83% <68.14%> (+0.03%) ⬆️
python 83.44% <89.38%> (-0.05%) ⬇️
sqlite 78.04% <80.53%> (+0.03%) ⬆️
unit 54.69% <62.83%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-ui-chart-controls/src/components/labelUtils.tsx 100.00% <ø> (ø)
...ackages/superset-ui-chart-controls/src/fixtures.ts 100.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
.../superset-ui-core/src/models/ExtensibleFunction.ts 100.00% <ø> (ø)
...ges/superset-ui-core/src/query/types/Datasource.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/query/types/Metric.ts 100.00% <ø> (ø)
...rts/src/BigNumber/BigNumberTotal/transformProps.ts 0.00% <0.00%> (ø)
.../plugins/plugin-chart-echarts/src/BoxPlot/index.ts 50.00% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/Funnel/index.ts 50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/index.ts 50.00% <ø> (ø)
... and 88 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit a6e749d into apache:master Jul 7, 2023
@cnabro cnabro deleted the fix/underbar branch July 7, 2023 16:24
@michael-s-molina michael-s-molina changed the title chore: remove underscore from builtin_time_grains label fix: remove underscore from builtin_time_grains label Jul 10, 2023
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 10, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants