fix: Incorrect dependency between filters related feature flags #24608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
the
v3.0
geido
approved these changes
Jul 7, 2023
michael-s-molina
added a commit
that referenced
this pull request
Jul 26, 2023
(cherry picked from commit 781a204)
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes incorrect dependencies between filters related feature flags. Specifically:
DASHBOARD_CROSS_FILTERSindependent ofDASHBOARD_NATIVE_FILTERS. Previously, ifDASHBOARD_NATIVE_FILTERSwas disabled andDASHBOARD_CROSS_FILTERSwas enabled, it would show native filters.DASHBOARD_NATIVE_FILTERS_SETdependent ofDASHBOARD_NATIVE_FILTERS. Previously, ifDASHBOARD_NATIVE_FILTERS_SETwas enabled andDASHBOARD_NATIVE_FILTERSwas disabled, it would lead to an inconsistent state because filter sets can't be applied if there are no native filters.Closes #24595
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Recording showing the new relationship between the feature flags:
Screen.Recording.2023-07-06.at.15.00.28.mov
TESTING INSTRUCTIONS
1 - Enable/disable the mentioned feature flags using different combinations
2 - Make sure the elements are rendered according to the new feature flag relationship
ADDITIONAL INFORMATION