fix(sqllab): missing column meta on autocomplete #24611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @sadpandajoe |
michael-s-molina
approved these changes
Jul 7, 2023
michael-s-molina
added
the
v3.0
|
@EugeneTorap It's generally a good practice to let the PR author to merge their PRs if they are committers to avoid ahead of time merges. @justinpark is a committer 😉 |
This was referenced Jul 13, 2023
michael-s-molina
pushed a commit
that referenced
this pull request
Jul 26, 2023
Co-authored-by: Justin Park <justinpark@apache.org> (cherry picked from commit ca8c8d2)
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Justin Park <justinpark@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Hotfix for regression from #24371
After table extended metadata discarded from sqlLab state, columns are no longer exists within
extendedTables.This commit adds the logic to extract the columns metadata from rdk query selectors.
FYI: Since AceEditorWrapper is hard to test the autocomplete specs, I'm planning to add specs for this including other autocomplete items in the upcoming PRs that will refactor setWords by a hook
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
after--columns-meta.mov
Before:
before--columns-meta.mov
TESTING INSTRUCTIONS
Enable autocomplete
Type some column name and check the autocomplete list including column names
ADDITIONAL INFORMATION