fix: Wrong positioning of filter tooltips on scroll

[michael-s-molina]

SUMMARY

Fixes the positioning of filter tooltips on scroll. Previously, the tooltips were unanchored to their elements and ended up in wrong positions when scrolling.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Tooltips following the scroll

Screen.Recording.2023-07-07.at.10.54.23.mov

After: Tooltips anchored to their elements

Screen.Recording.2023-07-07.at.11.08.47.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[ktmud]

Did this fix the popover of the time filter control, too?

[michael-s-molina]

Did this fix the popover of the time filter control, too

By time filter control, do you mean the one that appears in the video called time_range? If yes, then it's fixed.

[ktmud]

I meant this popover. Didn't see it in the video.

[michael-s-molina]

I meant this popover. Didn't see it in the video.

Oh, it's also following the scroll 🤦‍♂️ I'll add a commit to fix it

[codecov]

Codecov Report

Merging #24617 (d85aab6) into master (781a204) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head d85aab6 differs from pull request most recent head f333705. Consider uploading reports for the commit f333705 to get more accurate results

@@            Coverage Diff             @@
##           master   #24617      +/-   ##
==========================================
- Coverage   69.09%   69.09%   -0.01%     
==========================================
  Files        1906     1906              
  Lines       74127    74130       +3     
  Branches     8172     8172              
==========================================
  Hits        51220    51220              
- Misses      20780    20783       +3     
  Partials     2127     2127              

Flag	Coverage Δ
javascript	55.77% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...Filters/FilterBar/FilterControls/FilterControl.tsx	28.12% <0.00%> (-0.45%)	⬇️
...nts/controls/DateFilterControl/DateFilterLabel.tsx	60.60% <0.00%> (-1.25%)	⬇️
superset/db_engine_specs/base.py	90.98% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

@ktmud I'll add a follow-up to fix the popover element because it involves a shared component that is used in many use cases and may require additional context.

[michael-s-molina]

I registered the issue here.