fix: fix extra insert for count on dataset creation #24625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24625 +/- ##
==========================================
+ Coverage 68.97% 69.07% +0.10%
==========================================
Files 1907 1907
Lines 74153 74152 -1
Branches 8182 8182
==========================================
+ Hits 51148 51224 +76
+ Misses 20882 20805 -77
Partials 2123 2123
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
betodealmeida
approved these changes
Jul 7, 2023
john-bodley
reviewed
Jul 9, 2023
| @@ -52,7 +52,7 @@ def _prophet_fit_and_predict( # pylint: disable=too-many-arguments | |||
| Fit a prophet model and return a DataFrame with predicted results. | |||
| """ | |||
| try: | |||
| # pylint: disable=import-error,import-outside-toplevel | |||
| # pylint: disable=import-outside-toplevel | |||
There was a problem hiding this comment.
Thank you for fixing this warning.
john-bodley
reviewed
Jul 10, 2023
| @@ -47,9 +46,7 @@ def run(self) -> Model: | |||
| # Creates SqlaTable (Dataset) | |||
| dataset = DatasetDAO.create(self._properties, commit=False) | |||
|
|
|||
| # Updates columns and metrics from the dataset | |||
| dataset.metrics = [SqlMetric(metric_name="COUNT(*)", expression="COUNT(*)")] | |||
There was a problem hiding this comment.
@hughhhh would you mind linking to where this COUNT(*) metric is being created?
There was a problem hiding this comment.
dataset.fetch_metadata calls database.get_metrics
|
🏷️ preset:2023.27 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jul 10, 2023
(cherry picked from commit e6e8276)
michael-s-molina
added
the
v3.0
michael-s-molina
pushed a commit
that referenced
this pull request
Jul 26, 2023
(cherry picked from commit e6e8276)
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removing additional count() metric save, when .fetch_metadata() actually handles that work 😅
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION