Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump/relax Flask libs #24652

Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 11, 2023

SUMMARY

In #22355 the Flask libraries were bumped, however:

  1. Since then, Flask-WTF 1.1.0 has resolved an issue with JSONEncoder*
  2. The upper bounds on several of the packages were fairly restrictive—typically the upper bound should be exclusive of the next major version. Note overly restrictive constraints can be problematic when trying to resolve a feasible requirement space, especially for installations which include additional requirements.

* More specifically the error we (Airbnb) are seeing with Flask-WTF is:

.tox/py39/lib/python3.9/site-packages/flask_wtf/recaptcha/widgets.py:6: in <module>
  JSONEncoder = json.JSONEncoder
  E   AttributeError: module 'flask.json' has no attribute 'JSONEncoder'

This PR both bumps and relaxes the Flask libraries (where appropriate) and re-compiles the requirements for CI et al.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

cc: @EugeneTorap

@john-bodley john-bodley marked this pull request as ready for review July 11, 2023 00:13
@john-bodley john-bodley requested review from villebro, eugeniamz and michael-s-molina and removed request for eugeniamz and michael-s-molina July 11, 2023 00:13
@john-bodley john-bodley added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #24652 (d32c18a) into master (4881328) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d32c18a differs from pull request most recent head b8213ec. Consider uploading reports for the commit b8213ec to get more accurate results

@@            Coverage Diff             @@
##           master   #24652      +/-   ##
==========================================
+ Coverage   69.05%   69.07%   +0.02%     
==========================================
  Files        1907     1907              
  Lines       74151    74151              
  Branches     8182     8182              
==========================================
+ Hits        51204    51223      +19     
+ Misses      20824    20805      -19     
  Partials     2123     2123              
Flag Coverage Δ
hive 54.14% <ø> (ø)
mysql 79.47% <ø> (ø)
postgres 79.56% <ø> (ø)
presto 54.04% <ø> (ø)
python 83.54% <ø> (+0.05%) ⬆️
sqlite 78.12% <ø> (?)
unit 54.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 462418b into apache:master Jul 12, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants