Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure config is a dict in cross filters scope migration #24661

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

Addresses #24581 (comment).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @padbk

@kgabryje kgabryje requested a review from a team as a code owner July 11, 2023 13:28
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #24661 (94ad77b) into master (c53b249) will increase coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 94ad77b differs from pull request most recent head 421dece. Consider uploading reports for the commit 421dece to get more accurate results

@@            Coverage Diff             @@
##           master   #24661      +/-   ##
==========================================
+ Coverage   68.97%   68.99%   +0.01%     
==========================================
  Files        1907     1907              
  Lines       74153    74153              
  Branches     8182     8177       -5     
==========================================
+ Hits        51148    51161      +13     
+ Misses      20882    20872      -10     
+ Partials     2123     2120       -3     
Flag Coverage Δ
mysql 79.47% <ø> (?)
postgres 79.56% <ø> (-0.01%) ⬇️
presto 54.04% <ø> (+<0.01%) ⬆️
python 83.35% <ø> (+0.03%) ⬆️
sqlite 78.12% <ø> (-0.01%) ⬇️
unit 54.83% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.78% <ø> (ø)
superset-frontend/src/components/Icons/Icon.tsx 0.00% <ø> (ø)
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 9.09% <0.00%> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts 46.96% <0.00%> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 69.76% <0.00%> (ø)
...features/annotationLayers/AnnotationLayerModal.tsx 58.97% <ø> (ø)
...ntend/src/features/annotations/AnnotationModal.tsx 50.98% <ø> (ø)
...end/src/features/cssTemplates/CssTemplateModal.tsx 56.09% <ø> (ø)
superset/datasets/commands/create.py 100.00% <ø> (ø)
superset/examples/birth_names.py 70.00% <ø> (ø)
... and 8 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit 2e4d9f2 into apache:master Jul 11, 2023
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 12, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants