-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import database engine validation #24697
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24697 +/- ##
=======================================
Coverage 68.97% 68.98%
=======================================
Files 1901 1901
Lines 74006 74014 +8
Branches 8182 8182
=======================================
+ Hits 51045 51056 +11
+ Misses 20840 20837 -3
Partials 2121 2121
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit cb9b865)
(cherry picked from commit cb9b865)
SUMMARY
Fixes improves URI validation when importing databases, will work for importing datasets also.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION