feat: Add currencies controls in control panels #24718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
changed the title
kgabryje
force-pushed
the
feat/table-currency
branch
from
2c27041
to
af5544d
Compare
Codecov Report
@@ Coverage Diff @@
## master #24718 +/- ##
==========================================
- Coverage 67.17% 67.17% -0.01%
==========================================
Files 1902 1904 +2
Lines 73939 73965 +26
Branches 8176 8188 +12
==========================================
+ Hits 49672 49684 +12
- Misses 22154 22166 +12
- Partials 2113 2115 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@kgabryje would you mind adding some screenshots to the PR description? |
|
Thanks @john-bodley, added |
kgabryje
force-pushed
the
feat/table-currency
branch
from
6a0ac72
to
22fc493
Compare
|
/testenv up |
|
@kgabryje Ephemeral environment spinning up at http://35.162.241.129:8080. Credentials are |
eschutho
approved these changes
Aug 1, 2023
|
Ephemeral environment shutdown and build artifacts deleted. |
michael-s-molina
added
the
v3.0
michael-s-molina
pushed a commit
that referenced
this pull request
Sep 11, 2023
mistercrunch
added
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
PRs #24517 and #24594 introduced support for currencies for saved metrics defined on dataset level. This PR introduces currencies controls in control panel, which applies the currency formatting for all metrics in the chart.
Additionally, it restyles the column config popover in Table chart - introduced tabs "Display" and "Formatting" to make the popover cleaner.
Also, previously World Map didn't have number format control (nor a customize section). I added a Customize section and put number formatting and currency formatting in it.
The change affects all charts that already supported currencies for saved metrics - most of Echarts (including all Timeseries), Table, Pivot Table, World Map, Heatmap.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
New popover layout in Table chart:
Currency control in control panel:
Newly added Customize section in World Map:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION