docs: Specify correct postgresql yaml for overriding default passwords #24724
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| postgresPassword: superset | ||
| password: superset |
There was a problem hiding this comment.
In my opinion, it should be made clear that this is only one way to pass credentials to the Bitnami Postgres chart that the Superset chart depends on. In our deployment, we have an external process (Terraform) that creates Secrets for us, so we use the existingSecret mechanism from the Postgres chart, which imo is more secure since we're not committing any plaintext password to Git. I think that mentioning a few of the options and linking to the Postgres chart's documentation or even the Postgres chart's values file would be much more suitable. It is also worth noting that the Postgres chart is an optional dependency and people are free to "bring their own" Postgres...
|
Hi there, and thank you for the PR, but it seems to have gone a bit astray. I'll mark it as Draft for now since it's been in need of a rebase for quite some time, but please feel free to mark it as ready for review when ready, or let us know if you're no longer looking to pursue this. Thanks! |
SUMMARY
The existing yaml for setting the admin postgresql password is incorrect, just set up on a new kubernetes instance with the following yaml specified in PR. Also added the superset postgres user password as well, so that it could be changed as well.