Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: column/metric type icons look too small #24740

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jul 19, 2023

SUMMARY

cosmetic fixes in the control panel:

  • column/metric icons look too small (some regression)
  • tooltip was poorly designed, emphasis on the wrong place (label over actual info of data type), missing a space

Closes #24730

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen Shot 2023-07-18 at 5 41 56 PM #### after Screen Shot 2023-07-18 at 5 40 38 PM

before

Screen Shot 2023-07-18 at 5 41 50 PM

after

Screen Shot 2023-07-18 at 5 40 31 PM

TESTING INSTRUCTIONS

make sure things look good

@michael-s-molina
Copy link
Member

@mistercrunch I added "Closes #24730" to the PR description to automatically close the issue when this PR is merged.

@michael-s-molina
Copy link
Member

@mistercrunch @eschutho Is #24747 a duplicate of this PR or a complement to it?

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #24740 (348813f) into master (11bb8c3) will decrease coverage by 10.54%.
The diff coverage is 41.02%.

❗ Current head 348813f differs from pull request most recent head 2bfb41d. Consider uploading reports for the commit 2bfb41d to get more accurate results

@@             Coverage Diff             @@
##           master   #24740       +/-   ##
===========================================
- Coverage   68.89%   58.35%   -10.54%     
===========================================
  Files        1901     1901               
  Lines       73927    73933        +6     
  Branches     8183     8183               
===========================================
- Hits        50932    43146     -7786     
- Misses      20874    28666     +7792     
  Partials     2121     2121               
Flag Coverage Δ
javascript 55.71% <ø> (ø)
mysql ?
postgres ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/ColumnTypeLabel/ColumnTypeLabel.tsx 100.00% <ø> (ø)
...rontend/src/filters/components/Range/buildQuery.ts 0.00% <ø> (ø)
superset/charts/commands/warm_up_cache.py 27.77% <12.00%> (-69.73%) ⬇️
superset/views/core.py 34.20% <75.00%> (-36.15%) ⬇️
superset/charts/commands/export.py 52.94% <100.00%> (-41.18%) ⬇️
superset/databases/commands/importers/v1/utils.py 88.88% <100.00%> (-11.12%) ⬇️

... and 289 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mistercrunch mistercrunch merged commit 341b8d4 into apache:master Jul 21, 2023
26 checks passed
@mistercrunch mistercrunch deleted the fix_type_icons branch July 21, 2023 00:24
@eschutho
Copy link
Member

@mistercrunch @eschutho Is #24747 a duplicate of this PR or a complement to it?

complement

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 21, 2023
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Jul 21, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Really small icons on Explore
3 participants