-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make antd table font size same as data table #24741
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24741 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 1901 1901
Lines 73927 73927
Branches 8183 8183
=======================================
Hits 50932 50932
Misses 20874 20874
Partials 2121 2121
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Should the pagination also use a 12px font? |
@michael-s-molina idk, maybe. For now I'm overriding antd's definition of the class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mistercrunch Ant Design changes the pagination size when going from Large to Middle/Small but they keep the same size between Middle/Small. I guess to make it easier to click on the pages. Given that we don't currently support the Large size, I think we can mimic their behavior and keep things as they are. Thank you for the improvement.
Screen.Recording.2023-07-20.at.10.18.07.mov
(cherry picked from commit d1d5ff6)
SUMMARY
"Drill to details" uses normal font-size (14px) where all other data tables in Superset use small font size (12px). This sets our Table component based on AntD to use our
typography.sizes.s
while the table is set to a small size.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after
before