fix(native filter): clean deleted parent filter ids

[justinpark]

SUMMARY

When a parent filter has been removed, the cascadingParentIds has not updated accordingly.
This regression caused by the redux state mutation migration which remains filterConfigMap in obsolete dependency metadata because the redux action will update state.nativeFilters whereas filterConfigMap references from state.dashboardInfo.metadata.native_filter_configuration

This commit updates the cleanDeletedParents logic to retrieve the updated filterConfigMap data and then pass to the onSave payload in order to sync the latest updates.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

after--deleted-parent-id.mov

Before:

before--deleted-parent-id.mov

TESTING INSTRUCTIONS

Create a native filter and links a dependent filter
Hit save and then edit the native filter again
Remove the dependent filter only and then save
mouse over the filter has the dependent filter and see an error

ADDITIONAL INFORMATION

• Has associated issue: Error thrown when corrupted native dashboard filter metadata referencing obsolete filter ID #24729
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

Thanks @justinpark for the fix. I pushed a commit which includes a migration to remedy any corrupted dashboards. It would be good to verify said change in your environment.

[codecov]

Codecov Report

Merging #24749 (82455a5) into master (1a97245) will increase coverage by 0.04%.
The diff coverage is 88.88%.

❗ Current head 82455a5 differs from pull request most recent head b290341. Consider uploading reports for the commit b290341 to get more accurate results

@@            Coverage Diff             @@
##           master   #24749      +/-   ##
==========================================
+ Coverage   68.89%   68.93%   +0.04%     
==========================================
  Files        1901     1901              
  Lines       73925    73925              
  Branches     8183     8182       -1     
==========================================
+ Hits        50931    50963      +32     
+ Misses      20873    20848      -25     
+ Partials     2121     2114       -7     

Flag	Coverage Δ
hive	54.16% <ø> (ø)
javascript	55.79% <88.88%> (+0.08%)	⬆️
mysql	79.21% <ø> (ø)
postgres	79.30% <ø> (ø)
presto	54.06% <ø> (ø)
python	83.32% <ø> (ø)
sqlite	77.88% <ø> (ø)
unit	54.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	71.85% <88.88%> (+8.04%)	⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

LGTM. Thank you for the fix and added tests!

[justinpark]

Thanks justinpark for the fix. I pushed a commit which includes a migration to remedy any corrupted dashboards. It would be good to verify said change in your environment.

Confirmed the migration script worked well and the corrupted cascadingParentIds has been cleaned.

[john-bodley]

FYI @eschutho I wonder if you want to cherry-pick this into 2.1.1. Note there's a DB migration and thus you'll have to handle the version.