Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update AWS Athena and Redshift docs #24751

Merged
merged 2 commits into from
Jul 24, 2023
Merged

docs: update AWS Athena and Redshift docs #24751

merged 2 commits into from
Jul 24, 2023

Conversation

mdeshmu
Copy link
Contributor

@mdeshmu mdeshmu commented Jul 20, 2023

SUMMARY

update AWS Athena and Redshift docs

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

rusackas commented Jul 20, 2023

Paging @cbuffevant for a review (via the Database Familiarity Rolodex - sign on up, everyone!)

@john-bodley
Copy link
Member

cc @sfirke

Copy link

@cbuffevant cbuffevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM the Readshift part. I tried them out in our cluster.

@rusackas rusackas changed the title update AWS Athena and Redshift docs docs: update AWS Athena and Redshift docs Jul 21, 2023
@rusackas
Copy link
Member

redshift.mdx is failing the linter because of spaces at the ends of lines. If you can clean that up by hand or by running pre-commit run --all-files this should pass CI and be mergeable :)

@mdeshmu
Copy link
Contributor Author

mdeshmu commented Jul 22, 2023

Thanks for fixing the PR title and attempting to fix the lint issues @rusackas :)
I have run pre-commit and fixed the issues. All tests are green now.

Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the substance of the changes - they look like a nice addition! - but left a few small suggestions where there was a missing word or sentence that didn't read smoothly.

docs/docs/databases/redshift.mdx Outdated Show resolved Hide resolved
docs/docs/databases/redshift.mdx Outdated Show resolved Hide resolved
docs/docs/databases/redshift.mdx Show resolved Hide resolved
docs/docs/databases/redshift.mdx Outdated Show resolved Hide resolved
docs/docs/databases/athena.mdx Show resolved Hide resolved
@mdeshmu
Copy link
Contributor Author

mdeshmu commented Jul 24, 2023

thanks @sfirke for the review. I have addressed your comments.

@rusackas rusackas merged commit b8a3eef into apache:master Jul 24, 2023
28 checks passed
@mdeshmu mdeshmu deleted the update-redshift-docs branch August 10, 2023 03:24
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants