-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): Replace margin style by gap on query results #24772
fix(sqllab): Replace margin style by gap on query results #24772
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24772 +/- ##
==========================================
- Coverage 67.23% 58.41% -8.83%
==========================================
Files 1902 1902
Lines 73939 73997 +58
Branches 8176 8195 +19
==========================================
- Hits 49713 43224 -6489
- Misses 22113 28654 +6541
- Partials 2113 2119 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 350 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
const ResultContainer = styled.div` | ||
display: flex; | ||
flex-direction: column; | ||
gap: ${({ theme }) => theme.gridUnit * 2}px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is adding space vertically and horizontally while previously we had only vertical spacing with padding: ${({ theme }) => 2 * theme.gridUnit}px 0;
. Is this intended or should we use row-gap
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 4a81284)
SUMMARY
The horizontal scrollbar in query results has been cut off due to the top margin. There's a bunch of redundant margin for adjustment which makes this kind of overflow hidden regression.
This commit replaces this margins by the upper wrapper's gap as well as removing the antd style overrides.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Before:
TESTING INSTRUCTIONS
Go to sqllab and run a query that contains more than 20.
ADDITIONAL INFORMATION