fix(chore): switching between languages should be without timeout 60 seconds #24798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a fix for the problem of switching between languages. Currently, Superset has a 60-second timeout when switching languages due to using a memoized function. I added the locale as a dependency for that memoized function.
CC @bkyryliuk (44654e5)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
2023-07-25_15-57-26.mp4
After
2023-07-25_15-55-53.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION