fix: Python3.11 (str, Enum) issue #24803

EugeneTorap · 2023-07-25T17:14:19Z

SUMMARY

Changed Enum.format() (the default for format(), str.format() and f-strings) to always produce the same result as Enum.str(): for enums inheriting from ReprEnum it will be the member's value; for all other enums it will be the enum and member name (e.g. Color.RED).

Fix the next Py3.11 error

sqlalchemy.exc.ProgrammingError: (psycopg2.errors.SyntaxError) syntax error at or near "CtasMethod"
LINE 1: DROP CtasMethod.TABLE IF EXISTS test_sync_table

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2023-07-25T17:21:42Z

Codecov Report

Merging #24803 (fa98382) into master (4a81284) will increase coverage by 0.03%.
Report is 22 commits behind head on master.
The diff coverage is 85.45%.

❗ Current head fa98382 differs from pull request most recent head e96b24c. Consider uploading reports for the commit e96b24c to get more accurate results

@@            Coverage Diff             @@
##           master   #24803      +/-   ##
==========================================
+ Coverage   68.95%   68.99%   +0.03%     
==========================================
  Files        1902     1904       +2     
  Lines       73998    74081      +83     
  Branches     8195     8193       -2     
==========================================
+ Hits        51029    51115      +86     
+ Misses      20850    20845       -5     
- Partials     2119     2121       +2

Flag	Coverage Δ
hive	`54.14% <68.66%> (+<0.01%)`	⬆️
mysql	`79.21% <91.33%> (+0.02%)`	⬆️
postgres	`79.31% <91.33%> (+0.02%)`	⬆️
presto	`54.04% <68.66%> (+<0.01%)`	⬆️
python	`83.36% <91.33%> (+0.01%)`	⬆️
sqlite	`77.88% <91.33%> (+0.02%)`	⬆️
unit	`55.00% <78.66%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...et-chart-deckgl/src/layers/Geojson/controlPanel.ts	`50.00% <ø> (ø)`
...egacy-preset-chart-deckgl/src/layers/Path/Path.jsx	`0.00% <ø> (ø)`
...reset-chart-deckgl/src/layers/Path/controlPanel.ts	`50.00% <ø> (ø)`
...preset-chart-deckgl/src/layers/Polygon/Polygon.jsx	`0.00% <ø> (ø)`
...et-chart-deckgl/src/layers/Polygon/controlPanel.ts	`33.33% <ø> (ø)`
...reset-chart-deckgl/src/utilities/Shared_DeckGL.jsx	`86.48% <ø> (ø)`
superset-frontend/src/SqlLab/App.jsx	`0.00% <ø> (ø)`
...d/src/SqlLab/components/SaveDatasetModal/index.tsx	`60.63% <ø> (+10.63%)`	⬆️
superset-frontend/src/SqlLab/fixtures.ts	`100.00% <ø> (ø)`
...tersConfigModal/Footer/CancelConfirmationAlert.tsx	`100.00% <ø> (ø)`
... and 35 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

.github/workflows/superset-python-integrationtest.yml

mdeshmu · 2023-07-26T01:20:39Z

Please look into 3 failing tests.

This reverts commit f9ff25c.

EugeneTorap · 2023-07-26T07:17:50Z

Python-Integration / test-postgres (3.11) CI is passed with my changes

superset/utils/backports.py

john-bodley · 2023-07-28T17:02:58Z

.pylintrc

@@ -75,6 +75,7 @@ enable=
 # --disable=W"
 disable=
    cyclic-import,  # re-enable once this no longer raises false positives
+    no-member,  # re-enable once this no longer raises false positives


I mentioned the my concerns about blanket disabling of messages in the past. Is this a necessary requirement?

Yes, it's necessary requirement before we update min supported python to 3.11

Maybe we could add a note in the comment that this will become redundant after the min required version is 3.11

meanwhile raised the issue on pylint GitHub pylint-dev/pylint#8897

@villebro Added the note in the comment

villebro

LGTM, would love @john-bodley 's approval for merging

villebro · 2023-07-28T17:45:00Z

.pylintrc

@@ -75,6 +75,7 @@ enable=
 # --disable=W"
 disable=
    cyclic-import,  # re-enable once this no longer raises false positives
+    no-member,  # re-enable once this no longer raises false positives


Maybe we could add a note in the comment that this will become redundant after the min required version is 3.11

mdeshmu · 2023-07-30T04:14:17Z

I think, we also need to update files where str, enum.Enum is used.

EugeneTorap · 2023-07-31T05:44:28Z

Thanks @mdeshmu! Updated it.

EugeneTorap · 2023-07-31T15:11:55Z

Hey @john-bodley @michael-s-molina @rusackas! Can we merge this PR?

EugeneTorap requested review from villebro, geido, eschutho, rusackas, betodealmeida, nytai, mistercrunch, craig-rueda, john-bodley and kgabryje as code owners July 25, 2023 17:14

pull-request-size bot added the size/XS label Jul 25, 2023

EugeneTorap force-pushed the fix/python3.11-str-enum branch from b2e1f15 to 61e075e Compare July 25, 2023 18:05

Test Py3.11 integration test CI

f9ff25c

EugeneTorap force-pushed the fix/python3.11-str-enum branch from 61e075e to f9ff25c Compare July 25, 2023 18:12

Use backport StrEnum

cafe67e

pull-request-size bot added size/M and removed size/XS labels Jul 25, 2023

john-bodley reviewed Jul 25, 2023

View reviewed changes

.github/workflows/superset-python-integrationtest.yml Outdated Show resolved Hide resolved

Add custom backport StrEnum

0459a2b

pull-request-size bot added size/L and removed size/M labels Jul 26, 2023

Revert "Test Py3.11 integration test CI"

d3eaaad

This reverts commit f9ff25c.

Fix pylint

6df9450

john-bodley reviewed Jul 28, 2023

View reviewed changes

superset/utils/backports.py Show resolved Hide resolved

john-bodley reviewed Jul 28, 2023

View reviewed changes

villebro approved these changes Jul 28, 2023

View reviewed changes

Move (str, enum.Enum) to StrEnum

e96b24c

john-bodley approved these changes Jul 31, 2023

View reviewed changes

john-bodley merged commit 5f10307 into apache:master Jul 31, 2023
29 checks passed

EugeneTorap deleted the fix/python3.11-str-enum branch July 31, 2023 16:27

michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 1, 2023

michael-s-molina pushed a commit that referenced this pull request Aug 4, 2023

fix: Python3.11 (str, Enum) issue (#24803)

161e054

mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Python3.11 (str, Enum) issue #24803

fix: Python3.11 (str, Enum) issue #24803

EugeneTorap commented Jul 25, 2023 •

edited

Loading

codecov bot commented Jul 25, 2023 •

edited

Loading

mdeshmu commented Jul 26, 2023

EugeneTorap commented Jul 26, 2023 •

edited

Loading

john-bodley Jul 28, 2023

EugeneTorap Jul 28, 2023

villebro Jul 28, 2023

mdeshmu Jul 28, 2023

EugeneTorap Jul 31, 2023

villebro left a comment

villebro Jul 28, 2023

mdeshmu commented Jul 30, 2023

EugeneTorap commented Jul 31, 2023

EugeneTorap commented Jul 31, 2023

fix: Python3.11 (str, Enum) issue #24803

fix: Python3.11 (str, Enum) issue #24803

Conversation

EugeneTorap commented Jul 25, 2023 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Jul 25, 2023 • edited Loading

Codecov Report

mdeshmu commented Jul 26, 2023

EugeneTorap commented Jul 26, 2023 • edited Loading

john-bodley Jul 28, 2023

Choose a reason for hiding this comment

EugeneTorap Jul 28, 2023

Choose a reason for hiding this comment

villebro Jul 28, 2023

Choose a reason for hiding this comment

mdeshmu Jul 28, 2023

Choose a reason for hiding this comment

EugeneTorap Jul 31, 2023

Choose a reason for hiding this comment

villebro left a comment

Choose a reason for hiding this comment

villebro Jul 28, 2023

Choose a reason for hiding this comment

mdeshmu commented Jul 30, 2023

EugeneTorap commented Jul 31, 2023

EugeneTorap commented Jul 31, 2023

EugeneTorap commented Jul 25, 2023 •

edited

Loading

codecov bot commented Jul 25, 2023 •

edited

Loading

EugeneTorap commented Jul 26, 2023 •

edited

Loading