-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass schema on dataset creation #24815
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24815 +/- ##
==========================================
- Coverage 68.84% 68.83% -0.01%
==========================================
Files 1902 1903 +1
Lines 73997 74006 +9
Branches 8195 8193 -2
==========================================
- Hits 50944 50943 -1
- Misses 20934 20942 +8
- Partials 2119 2121 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@betodealmeida can you add a test? :) |
Adding it right now! |
(cherry picked from commit ba508a7)
🏷️ preset:2023.29 |
(cherry picked from commit ba508a7)
SUMMARY
For some reason we were not passing the
schema
when creating a dataset from SQL Lab.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION