Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass schema on dataset creation #24815

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix: pass schema on dataset creation #24815

merged 2 commits into from
Jul 27, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

For some reason we were not passing the schema when creating a dataset from SQL Lab.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #24815 (b26fa71) into master (165afee) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 77.27%.

❗ Current head b26fa71 differs from pull request most recent head 8d13e2c. Consider uploading reports for the commit 8d13e2c to get more accurate results

@@            Coverage Diff             @@
##           master   #24815      +/-   ##
==========================================
- Coverage   68.84%   68.83%   -0.01%     
==========================================
  Files        1902     1903       +1     
  Lines       73997    74006       +9     
  Branches     8195     8193       -2     
==========================================
- Hits        50944    50943       -1     
- Misses      20934    20942       +8     
- Partials     2119     2121       +2     
Flag Coverage Δ
javascript 55.84% <77.27%> (+0.04%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
superset-frontend/src/SqlLab/App.jsx 0.00% <ø> (ø)
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 60.63% <ø> (+10.63%) ⬆️
superset-frontend/src/SqlLab/fixtures.ts 100.00% <ø> (ø)
...tersConfigModal/Footer/CancelConfirmationAlert.tsx 100.00% <ø> (ø)
superset-frontend/src/hooks/apiResources/tables.ts 73.80% <ø> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 71.09% <50.00%> (+0.13%) ⬆️
...t-frontend/src/components/AsyncAceEditor/index.tsx 91.66% <63.63%> (+0.55%) ⬆️
.../SqlLab/components/AceEditorWrapper/useKeywords.ts 80.00% <80.00%> (ø)
...d/src/SqlLab/components/AceEditorWrapper/index.tsx 68.42% <100.00%> (+2.15%) ⬆️
...uperset-frontend/src/hooks/apiResources/schemas.ts 65.62% <100.00%> (ø)

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho
Copy link
Member

@betodealmeida can you add a test? :)

@betodealmeida
Copy link
Member Author

@betodealmeida can you add a test? :)

Adding it right now!

@betodealmeida betodealmeida merged commit ba508a7 into master Jul 27, 2023
51 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 27, 2023
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 28, 2023
@sadpandajoe
Copy link
Member

🏷️ preset:2023.29

villebro pushed a commit that referenced this pull request Aug 2, 2023
michael-s-molina pushed a commit that referenced this pull request Aug 4, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the sc-72631 branch March 26, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants