Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding a couple links to contributing page #24817

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

Just adding a few links.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Should be pretty straighforward from the markdown mods, but I can spin up the server and take screenshots if warranted.

TESTING INSTRUCTIONS

Make sure it looks right when merged (it sure should!) but we can roll back if I goofed something up.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member Author

@sfirke for review/comments/additions

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #24817 (68ba2d8) into master (4b1f1d4) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24817      +/-   ##
==========================================
+ Coverage   68.82%   68.97%   +0.14%     
==========================================
  Files        1903     1903              
  Lines       74006    74006              
  Branches     8193     8193              
==========================================
+ Hits        50933    51042     +109     
+ Misses      20957    20848     -109     
  Partials     2116     2116              
Flag Coverage Δ
hive 54.16% <ø> (?)
javascript 55.81% <ø> (ø)
mysql 79.19% <ø> (ø)
postgres 79.29% <ø> (ø)
presto 54.06% <ø> (?)
python 83.35% <ø> (+0.30%) ⬆️
sqlite 77.86% <ø> (ø)
unit 54.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas force-pushed the rusackas-contributing-links branch from abcfb5c to 68ba2d8 Compare July 26, 2023 22:11
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit a1396d0 into master Jul 27, 2023
56 checks passed
@rusackas rusackas deleted the rusackas-contributing-links branch July 27, 2023 19:27
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants