Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration): Ensure cascadeParentIds key exists #24831

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

john-bodley
Copy link
Member

SUMMARY

Sorry this issue only surfaced whilst testing on a more recent corpus of Airbnb's data. It seems that there could be instances where the cascadeParentIds key does not exist for a given native dashboard filter. This change adds a safeguard for such an event.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch and removed size/XS labels Jul 28, 2023
@john-bodley john-bodley marked this pull request as ready for review July 28, 2023 05:05
@john-bodley john-bodley requested a review from a team as a code owner July 28, 2023 05:05
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #24831 (c24a1ed) into master (5bb8e0d) will not change coverage.
The diff coverage is n/a.

❗ Current head c24a1ed differs from pull request most recent head e6747b9. Consider uploading reports for the commit e6747b9 to get more accurate results

@@           Coverage Diff           @@
##           master   #24831   +/-   ##
=======================================
  Coverage   68.99%   68.99%           
=======================================
  Files        1903     1903           
  Lines       74072    74072           
  Branches     8193     8193           
=======================================
  Hits        51104    51104           
  Misses      20847    20847           
  Partials     2121     2121           
Flag Coverage Δ
hive 54.13% <ø> (ø)
mysql 79.21% <ø> (ø)
postgres 79.31% <ø> (ø)
presto 54.03% <ø> (ø)
python 83.36% <ø> (ø)
sqlite 77.88% <ø> (ø)
unit 54.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit caffe3c into master Jul 28, 2023
@john-bodley john-bodley deleted the john-bodley--fix-24749 branch July 28, 2023 20:54
michael-s-molina pushed a commit that referenced this pull request Aug 4, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants