Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Links in tooltips of dashboard chart cards #24846

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jul 31, 2023

SUMMARY

Fixes a bug where the dataset names were being displayed as links inside the tooltips of dashboard chart cards.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-07-31 at 11 01 22 Screenshot 2023-07-31 at 11 28 08

TESTING INSTRUCTIONS

Make sure the dataset names are not links in the tooltips

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #24846 (de0fc24) into master (77889b2) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head de0fc24 differs from pull request most recent head 80f9f84. Consider uploading reports for the commit 80f9f84 to get more accurate results

@@            Coverage Diff             @@
##           master   #24846      +/-   ##
==========================================
- Coverage   68.99%   68.99%   -0.01%     
==========================================
  Files        1903     1903              
  Lines       74073    74074       +1     
  Branches     8193     8194       +1     
==========================================
  Hits        51108    51108              
- Misses      20844    20847       +3     
+ Partials     2121     2119       -2     
Flag Coverage Δ
javascript 55.83% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...dashboard/components/AddSliceCard/AddSliceCard.tsx 68.88% <100.00%> (+5.25%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@kasiazjc kasiazjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design wise - all good!

@michael-s-molina michael-s-molina merged commit ea17dd6 into apache:master Aug 1, 2023
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 1, 2023
michael-s-molina added a commit that referenced this pull request Aug 4, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants