-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(legacy-chart): corrupted raw chart data #24850
fix(legacy-chart): corrupted raw chart data #24850
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24850 +/- ##
=======================================
Coverage 68.99% 69.00%
=======================================
Files 1903 1904 +1
Lines 74072 74106 +34
Branches 8193 8193
=======================================
+ Hits 51107 51137 +30
- Misses 20844 20848 +4
Partials 2121 2121
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 1c5971d)
(cherry picked from commit 1c5971d)
SUMMARY
In legacy charts, there's some logics mutating chartData which also corrupts the original raw data.
This makes the invalid chart results specially in the stacked chart which sums up the series values for the chart data.
This commit makes the copy of the rawData value to avoid the corruption.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
after--polluted-rawData.mov
Before:
before--polluted-rawData.mov
TESTING INSTRUCTIONS
.3s
ADDITIONAL INFORMATION